View previous topic :: View next topic |
Author |
Message |
aaronc542
Joined: 22 May 2007 Posts: 35 Location: NJ, USA
|
Posted: Wed Jan 30, 2008 9:15 pm Post subject: Access to internal conduit |
|
|
As far as I can tell, the writeRecord allocates a new buffer each time it is called. I would like to be able to implement a non-allocating version of the conduit (if you look at the Sendero project, you will see that I am working on a FCGI backend based on your library). This would be possible with access to the underlying FastCGIInternalConduit and id from the FastCGIRequest class. The following additions to FastCGIRequest would take care of it:
Code: |
FastCGIInternalConduit conduit()
{
return conduit_;
}
uint id()
{
return id_;
}
|
What do you think? If you liked, you could even include the fixed-allocation version that I am working on for Sendero in your library. Thanks for this library btw - it is very useful! |
|
Back to top |
|
|
xammy
Joined: 01 Feb 2007 Posts: 6 Location: Magdeburg, Germany
|
Posted: Thu Jan 31, 2008 8:06 am Post subject: |
|
|
I've patched the repository with those two functions... Hopefully, this is all the way you like.
I think it would be nice, if this fixed-allocation thing could be integrated. If it's not too much work - could you submit it as a patch? Or is it integrated in Sendero too much and must be refactored somehow? When I've some time for it, I will take a look at it! |
|
Back to top |
|
|
aaronc542
Joined: 22 May 2007 Posts: 35 Location: NJ, USA
|
Posted: Thu Jan 31, 2008 8:34 am Post subject: |
|
|
Thanks! This should work. I don't think it should be too complex to integrate. Once I've tested it enough, I'll suggest a patch. |
|
Back to top |
|
|
|