[darkuranium]

Hey, I'd like to report some errors that I've noticed in a few derelict modules (and a new module). Here they are:

New files (I would have created patches, but the tool seems screwy):
vorbiscodec.d: http://paste.dprogramming.com/dpht0899
vorbisfile.d: http://paste.dprogramming.com/dprii23a
ogg.d: http://paste.dprogramming.com/dpr5jpok

---------------------- UPDATE ------------------------
The files can now be found here:
http://soulbreakers.com/usr/darkman/d/derelict/
--------------------------------------------------------

DerelictVorbis:
vorbiscodec.d changes:
-Vorbis seems to use libvorbis.dll, not vorbis.dll. I would have renamed them all (see vorbisfile.d and ogg.d), but libvorbis.dll wants libogg.dll, not ogg.dll. Note that this has to be prepended, as the binaries that come with the app (which are usually the most compatiable) are most probably going to be libvorbis.dll, not vorbis.dll (perhaps the missing lib is part of the older version?) -- see http://xiph.org/downloads/ (vorbis-tools 1.2.0 (win32 binaries))

vorbisfile.d changes:
-ov_fopen was missing. Added -- see http://www.xiph.org/vorbis/doc/vorbisfile/ov_fopen.html
-ov_test used FILE*, made it call ov_test_callbacks, just like ov_open
-Vorbis seems to use libvorbisfile.dll, instead of vorbisfile.dll -- prepended to the list of DLLs

DerelictOgg:
ogg.d changes:
-added libogg.dll to the list of libs


Also, I created some new bindings, DerelictALUT. I was thinking that you could add it to the list of unofficial bindings (although they were created to work just like the official ones).

I also cleaned up the DerelictGLFW code, the bindings work much more like the official ones now. It will also be uploaded.

I think I'm going to add tests for each of these (ALUT/GLFW), once I get time.

[aldacron]

The difference between the DLL names might have to do with which compiler toolchain is used. By convention, some libraries on Windows are created as lib*.dll when using MingW or Cygwin and as *.dll when using MSVC. That's just a guess, though, as I've not looked at the make files for libogg or libvorbis. But googling shows that both forms (ogg.dll and libogg.dll) are floating around out there in the wild. So I'll add your fixes when I update the ogg/vorbis stuff to the latest version.

As for ALUT, I just removed support for some ALUT functions from al.d. In the headers I used to create the initial binding, there were only a handful of alut functions. They were declared in al.h, special-cased for Windows, and not a separate download. When I updated recently, I saw the alut stuff had been removed from al.h. I didn't realize it was a separate download now.

I don't know anything about alut. Is it widely used? Is it cross-platform now? Is it an official openal library or is it more like glut? I'll look into this and if it seems worth while, I'll add your binding to DerelictAL. I won't add a new package for it. I'm going to be combining several related packages in the near future (such as DerelictGL/GLU).
_________________
The One With D | The One With Aldacron | D Bits

[darkuranium]

[aldacron]

[darkuranium]

Well, apparently, even in the newest libvorbis.dll, ov_fopen() does not exist (despite it being documented), so perhaps it should be commented out for now.

EDIT: And you forgot to add ov_test wrapper instead of the function, because it uses FILE* too (same applies to it as to ov_open):

[aldacron]

OK, updated the trunk with the changes. And you are absolutely right in that I did forget. It's probably a good idea if you add a new ticket when you have fixes/changes to suggest in future. I don't check the tickets every day, but I do check them eventually. These forum threads often fall off of my radar and I forget about them if they aren't updated again.
_________________
The One With D | The One With Aldacron | D Bits

[h3r3tic]

One more thing to do :> Line 103 in http://dsource.org/projects/derelict/browser/trunk/DerelictVorbis/derelict/ogg/vorbisfile.d?rev=324#L103 should be removed or you get "derelict/ogg/vorbisfile.d(103): function derelict.ogg.vorbisfile.ov_test (_iobuf*,OggVorbis_File*,char*,long) does not match parameter types ()"

[aldacron]

Thanks, Tom. Fixed.
_________________
The One With D | The One With Aldacron | D Bits