Changeset 630:bc83491463f0

Timestamp:

10/01/08 15:14:15 (3 months ago)

Author:

Christian Kamm <kamm incasoftware de>

branch:

default

Message:

Nicer error message on some invalid default args.

Files:

• dmd/mtype.c (modified) (1 diff)

dmd/mtype.c

@@ -2935 +2935 @@
-        arg->defaultArg = resolveProperties(sc, arg->defaultArg);
-        arg->defaultArg = arg->defaultArg->implicitCastTo(sc, arg->type);
+
+        // make sure default arguments only use variables with lower protection
+        // this check only catches the common case that the default arg Exp is a VarExp
+        if(arg->defaultArg->op == TOKvar)
+        {   VarExp *ve = (VarExp *)arg->defaultArg;
+            if(ve->var->protection < sc->protection)
+            error(loc, "default argument %s has stronger protection than function %s", ve->var->toChars(), toChars());
+        }
-        }
-