Changeset 1914

Timestamp:

08/22/10 01:54:08 (14 years ago)

Author:

dsimcha

Message:

Bug 4700: to!float("0") fails

Files:

• trunk/docsrc/changelog.dd (modified) (1 diff)
• trunk/phobos/std/conv.d (modified) (4 diffs)

trunk/docsrc/changelog.dd

@@ -38 +38 @@
-    $(LI $(BUGZILLA 4345): More flexible std.array.array.)
-    $(LI $(BUGZILLA 4363): Some phobos ranges are not forward ranges (but should be).)
-    $(LI $(BUGZILLA 4381): Length attribute for std.typecons.Tuple.)
-    $(LI $(BUGZILLA 4387): std.range.Cycle assumes lvalue elements.)
-    $(LI $(BUGZILLA 4388): std.range.Radial assumes lvalue elements.)
-    $(LI $(BUGZILLA 4403): std.range.FrontTransversal assumes lvalue elements.)
-    $(LI $(BUGZILLA 4404): std.range.Transversal assumes lvalue elements.)
-    $(LI $(BUGZILLA 4455): Taking the sqrt of an integer shouldn't require an explicit cast.)
-    $(LI $(BUGZILLA 4464): std.range.take does not always return Take!R.)
-    $(LI $(BUGZILLA 4603): array(iota(1, 0)) error.)
+    $(LI $(BUGZILLA 4700): to!float("0") fails)
-    )
-)
-
-
-<div id=version>
-$(UL
-    $(NEW 049)
-    $(NEW 048)
-    $(NEW 047)
-    $(NEW 046)

trunk/phobos/std/conv.d

@@ -1225 +1225 @@
-    }
-    char sign = 0;                       /* indicating +                 */
-    switch (p.front)
-    {
-        case '-': sign++; goto case '+';
-        case '+': p.popFront(); enforce(!p.empty,
-                new ConvError("error converting input to floating point"));
-        default: {}
-    }
-
-
-
+
+
+
+
+
+
+
+
+
+
+
-
-    real ldval = 0.0;
-    char dot = 0;                        /* if decimal point has been seen */
-    int exp = 0;
-    long msdec = 0, lsdec = 0;
-    ulong msscale = 1;
-
-    if (isHex)
-    {
-        int guard = 0;
@@ -2281 +2290 @@
-    f = to!float( "123e+2" );
-    assert( f == 123e+2f );
-
-    f = to!float( "123e-2" );
-    assert( f == 123e-2f );
-    f = to!float( "123." );
-    assert( f == 123.f );
-    f = to!float( ".456" );
-    assert( f == .456f );
-
+    assert(to!float("0") == 0f);
+    assert(to!float("-0") == -0f);
+
-    // min and max
-    try
-    {
-        f = to!float("1.17549e-38");
-        assert(feq(cast(real)f, cast(real)1.17549e-38));
-        assert(feq(cast(real)f, cast(real)float.min_normal));
-        f = to!float("3.40282e+38");
-        assert(to!string(f) == to!string(3.40282e+38));
-    }
-    catch (ConvError e) // strtof() bug on some platforms
@@ -2339 +2351 @@
-    assert( d == 123e2);
-    d = to!double( "123e-2" );
-    assert( d == 123e-2 );
-    d = to!double( "123." );
-    assert( d == 123. );
-    d = to!double( ".456" );
-    assert( d == .456 );
-    d = to!double( "1.23456E+2" );
-    assert( d == 1.23456E+2 );
-
+    assert(to!double("0") == 0.0);
+    assert(to!double("-0") == -0.0);
+
-    // min and max
-    try
-    {
-        d = to!double("2.22508e-308");
-        assert(feq(cast(real)d, cast(real)2.22508e-308));
-        assert(feq(cast(real)d, cast(real)double.min_normal));
-        d = to!double("1.79769e+308");
-        assert(to!string(d) == to!string(1.79769e+308));
-        assert(to!string(d) == to!string(double.max));
-    }
@@ -2400 +2415 @@
-    assert(feq(r, 1.23L));
-    r = to!real("123.");
-    assert(r == 123L);
-    r = to!real(".456");
-    assert(r == .456L);
-
-    r = to!real("1.23456e+2");
-    assert(feq(r,  1.23456e+2L));
-    r = to!real(to!string(real.max / 2L));
-    assert(to!string(r) == to!string(real.max / 2L));
+
+    assert(to!real("0") == 0.0L);
+    assert(to!real("-0") == -0.0L);
-
-    // min and max
-    try
-    {
-        r = to!real(to!string(real.min_normal));
-        assert(to!string(r) == to!string(real.min_normal));
-        r = to!real(to!string(real.max));
-        assert(to!string(r) == to!string(real.max));
-    }
-    catch (ConvError e) // strtold() bug on some platforms