Changeset 1953

Timestamp:

09/04/10 14:34:11 (14 years ago)

Author:

dsimcha

Message:

Bug 4810: dotProduct problem with ints

Files:

• trunk/docsrc/changelog.dd (modified) (1 diff)
• trunk/phobos/std/numeric.d (modified) (3 diffs)

trunk/docsrc/changelog.dd

@@ -43 +43 @@
-    $(LI $(BUGZILLA 4381): Length attribute for std.typecons.Tuple.)
-    $(LI $(BUGZILLA 4387): std.range.Cycle assumes lvalue elements.)
-    $(LI $(BUGZILLA 4388): std.range.Radial assumes lvalue elements.)
-    $(LI $(BUGZILLA 4403): std.range.FrontTransversal assumes lvalue elements.)
-    $(LI $(BUGZILLA 4404): std.range.Transversal assumes lvalue elements.)
-    $(LI $(BUGZILLA 4455): Taking the sqrt of an integer shouldn't require an explicit cast.)
-    $(LI $(BUGZILLA 4464): std.range.take does not always return Take!R.)
-    $(LI $(BUGZILLA 4603): array(iota(1, 0)) error.)
-    $(LI $(BUGZILLA 4700): to!float("0") fails)
-    $(LI $(BUGZILLA 4789): std.algorithm.sort bug)
+    $(LI $(BUGZILLA 4810): dotProduct problem with ints)
-    )
-)
-
-
-<div id=version>
-$(UL
-    $(NEW 049)
-    $(NEW 048)
-    $(NEW 047)
-    $(NEW 046)

trunk/phobos/std/numeric.d

@@ -536 +536 @@
-
-unittest
-{
-    alias TypeTuple!(
-        CustomFloat!(5, 10),
-        CustomFloat!(5, 11, CustomFloatFlags.ieee ^ CustomFloatFlags.signed),
-        CustomFloat!(1, 15, CustomFloatFlags.ieee ^ CustomFloatFlags.signed),
-        CustomFloat!(4, 3, CustomFloatFlags.ieee | CustomFloatFlags.probability ^ CustomFloatFlags.signed)
-
-        ) FPTypes;
-
-    pragma(msg, " --- std.numeric(" ~ __LINE__.stringof ~ ") CustomFloat broken test ---");
-
-
-    foreach (F; FPTypes)
-    {
-        auto x = F(0.125);
-        assert(x.get!float == 0.125F);
-        assert(x.get!double == 0.125);
-
-        x -= 0.0625;
-        assert(x.get!float == 0.0625F);
-        assert(x.get!double == 0.0625);
@@ -1236 +1233 @@
-    return result;
-}
-
-/// Ditto
-Unqual!(CommonType!(F1, F2))
-dotProduct(F1, F2)(in F1[] avector, in F2[] bvector)
-{
-    immutable n = avector.length;
-    assert(n == bvector.length);
-    auto avec = avector.ptr, bvec = bvector.ptr;
-.0, sum1 = 0.
+, sum1 = 
-
-    const all_endp = avec + n;
-    const smallblock_endp = avec + (n & ~3);
-    const bigblock_endp = avec + (n & ~15);
-
-    for (; avec != bigblock_endp; avec += 16, bvec += 16)
-    {
-        sum0 += avec[0] * bvec[0];
-        sum1 += avec[1] * bvec[1];
-        sum0 += avec[2] * bvec[2];
@@ -1283 +1280 @@
-        sum0 += (*avec++) * (*bvec++);
-
-    return sum0;
-}
-
-unittest
-{
-    double[] a = [ 1., 2., ];
-    double[] b = [ 4., 6., ];
-    assert(dotProduct(a, b) == 16);
+    assert(dotProduct([1, 3, -5], [4, -2, -1]) == 3);
-}
-
-/**
-Computes the $(LUCKY cosine similarity) of input ranges $(D a) and $(D
-b). The two ranges must have the same length. If both ranges define
-length, the check is done once; otherwise, it is done at each
-iteration. If either range has all-zero elements, return 0.
- */
-CommonType!(ElementType!(Range1), ElementType!(Range2))
-cosineSimilarity(Range1, Range2)(Range1 a, Range2 b)