Changeset 1954

Timestamp:

03/22/07 19:06:30 (2 years ago)

Author:

jcomellas

Message:

* Removed dependency on tango.io.Stdout for non-debug builds.
* On POSIX platforms, the environment was not being passed correctly to child

processes. This commit should fix ticket #348.

Files:

• trunk/tango/sys/Process.d (modified) (8 diffs)

trunk/tango/sys/Process.d

@@ -8 +8 @@
-
-private import tango.io.FileConst;
-Stdout
+Console
-private import tango.io.Buffer;
-private import tango.sys.Common;
@@ -26 +26 @@
-    private import tango.stdc.posix.unistd;
-    private import tango.stdc.posix.sys.wait;
+}
+
+debug (Process)
+{
+    private import tango.io.Stdout;
-}
-
@@ -769 +774 @@
-                        // the format expected by the execv() family of functions.
-                        argptr = toNullEndedArray(_args);
-toNullEndedArray(_env
+(_env.length > 0 ? toNullEndedArray(_env) : null
-
-                        // Switch to the working directory if it has been set.
@@ -783 +788 @@
-                        if (rc == -1)
-                        {
-
-
+
-
-                            try
@@ -802 +806 @@
-                    else
-                    {
-Stderr.formatln("Failed to set notification pipe to close-on-exec for {0}: {1}",
-            _args[0], SysError.lastMsg)
+Cerr("Failed to set notification pipe to close-on-exec for ")
+(_args[0])(": ")(SysError.lastMsg).newline
-                        exit(errno);
-                    }
@@ -1345 +1349 @@
-                        path ~= FileConst.PathSeparatorChar;
-                    }
+
+                    debug (Process)
+                        Stdout.formatln("Trying execution of '{0}' in directory '{1}'",
+                                        filename, path);
+
-                    path ~= filename;
-
-
+
+
+
-                    // If the process execution failed because of an error
-                    // other than ENOENT (No such file or directory) we
@@ -1359 +1369 @@
-            else
-            {
-
+
+
+
+
+
+
-            }
-            return rc;
@@ -1471 +1486 @@
-        catch (ProcessException e)
-        {
-Stdout.formatln("Program execution failed: {0}", e.toUtf8()
+Cerr("Program execution failed: ")(e.toUtf8()).newline(
-        }
-    }