Changeset 3800

Timestamp:

07/25/08 15:30:46 (4 months ago)

Author:

sean

Message:

Whoever came up with the rule that "synchronized" without a "(this)" inside a class member function would synchronize on the global monitor instead of the instance monitor was smoking crack. This is completely ridiculous. I've fixed the instances where we were using unlabeled "synchronized" inside of the ThreadGroup? object. This closes #1171

Files:

• trunk/lib/common/tango/core/Thread.d (modified) (6 diffs)

trunk/lib/common/tango/core/Thread.d

@@ -2113 +2113 @@
-
-        t.start();
-
+( this )
-        {
-            m_all[t] = t;
@@ -2136 +2136 @@
-
-        t.start();
-
+( this )
-        {
-            m_all[t] = t;
@@ -2160 +2160 @@
-    body
-    {
-
+( this )
-        {
-            m_all[t] = t;
@@ -2184 +2184 @@
-    body
-    {
-
+( this )
-        {
-            m_all.remove( t );
@@ -2196 +2196 @@
-    final int opApply( int delegate( inout Thread ) dg )
-    {
-
+( this )
-        {
-            int ret = 0;
@@ -2226 +2226 @@
-    final void joinAll( bool rethrow = true )
-    {
-
+( this )
-        {
-            // NOTE: This loop relies on the knowledge that m_all uses the