Ticket #1902 (reopened defect)

Opened 14 years ago

Last modified 14 years ago

toAddrString, toPortString and some improvements for IPv6

Reported by:	Wazar	Assigned to:	kris
Priority:	major	Milestone:	1.0
Component:	Tango	Version:	trunk
Keywords:		Cc:	wazar, larsivi

Attachments

Berkeley.patch (3.9 kB) - added by Wazar on 04/25/10 16:14:16.
WS2_32.lib (20.0 kB) - added by Wazar on 05/11/10 17:43:11.: Created with implib from ws2_32.dll
Berkeley.2.patch (11.8 kB) - added by Wazar on 05/12/10 17:09:35.
WsaSock.patch (296 bytes) - added by Wazar on 05/12/10 17:09:49.

Change History

04/09/10 16:55:05 changed by Wazar

Maybe this should make all the Address in a separate module?

04/25/10 15:00:53 changed by larsivi

Does this patch fix the issue with the unittest? it seems that ia.toString drops all leading 0's in IPv6 segments.

04/25/10 16:14:16 changed by Wazar

attachment Berkeley.patch added.

04/25/10 16:18:42 changed by Wazar

Updated patch. Now it fixes unittest. toString method truncate the leading 0's in address.

04/25/10 19:54:49 changed by larsivi

Great work Wazar! Did you by any chance read this post? http://www.dsource.org/projects/tango/forums/topic/877

05/09/10 23:08:05 changed by kris

status changed from new to closed.
resolution set to fixed.

(In [5442]) fixes #1902 :: toAddrString, toPortString and some improvements for IPv6

kudos to Wazar

05/10/10 06:58:40 changed by kris

cc set to wazar.
status changed from closed to reopened.
resolution deleted.

wazar: inet_ntop() doesn't exist on windows ... can you fix, please?

05/11/10 17:43:11 changed by Wazar

attachment WS2_32.lib added.

Created with implib from ws2_32.dll

05/11/10 17:44:26 changed by Wazar

I have attach library. Patch will be tomorrow.

05/12/10 17:09:35 changed by Wazar

attachment Berkeley.2.patch added.

05/12/10 17:09:49 changed by Wazar

attachment WsaSock.patch added.

05/12/10 17:12:03 changed by Wazar

This patches must work with attached WS2_32.lib and fixes this ticket and #1239

05/16/10 02:34:29 changed by kris

thanks :)

07/17/10 02:14:29 changed by kris

cc changed from wazar to wazar, larsivi.

larsivi: how are we gonna package and/or distribute this fix? It needs the replacement ws2_32.lib to be bundled, and thus will not work for those without that lib (e.g. anyone using trunk)

07/17/10 19:05:29 changed by kris

Wazar: I see the functions decls have changed from extern(Windows) to be extern(C) instead. Did MS change the function decls in the WS2_32.dll? Is there some other reason why these have changed? Just seems very unusual for them to break compatibility like that

07/19/10 01:16:07 changed by kris

Well, if you compile a win32 version of Berkeley.d (with a main(){} added) it has a write exception at startup. Seems to have something to do with the implib generated ws2_32.lib

07/19/10 01:18:00 changed by kris

also, we cannot use inet_ntop() on windows since it was introduced only with Vista. Doesn't exist on Windows prior to that

Ticket Navigation