Log.d: Prevent allocation through concatination

This patch makes the code,

• harder to read,
• introduces a slightly higher stack use and
• makes it quite a bit faster

Ihmho, library code is allowed to be a bit harder to read.

(In [5675]) Fix #2066: allocate less when searching for a Logger.

Thanks to Marenz for the patch.

shouldn't be doing lookups often at all .. they should be done once and the Logger references stored at module-scope.

I feel this is a misunderstanding over usage, rather than something that needs to be made faster. If you're concerned about speed, it's a whole lot faster to not invoke this at all (other than for initialization purposes).

Replying to kris:

shouldn't be doing lookups often at all .. they should be done once and the Logger references stored at module-scope. I feel this is a misunderstanding over usage, rather than something that needs to be made faster. If you're concerned about speed, it's a whole lot faster to not invoke this at all (other than for initialization purposes).

yea, eventually mwarning and me got to the same conclusion.. it was a rather specific and hacky testcase. I was aware that it wasn't meant to be used like that, but at the moment it was easier to do it like that than to add a logger variable and use that.. it was fast hack to output stuff to a certain logger and that's how I found it.. so yea, let's close this.. though we need to revert the commit, right?